fix(trie): empty value encoding for leaves #2958
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #2958 +/- ##
===============================================
- Coverage 63.46% 63.38% -0.08%
===============================================
Files 218 218
Lines 27505 27504 -1
===============================================
- Hits 17455 17434 -21
- Misses 8445 8467 +22
+ Partials 1605 1603 -2 |
qdm12
force-pushed
the
qdm12/trie/fix-empty-value-encoding
branch
from
c30c80a
to
26da12f
Compare
qdm12
force-pushed
the
qdm12/trie/fix-empty-value-encoding
branch
from
26da12f
to
0dff61a
Compare
|
Wrong implementation and closed in favor of #2964 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Issues
Primary Reviewer